Skip to content

Conversation

gpshead
Copy link
Member

@gpshead gpshead commented Oct 16, 2025

cherry-pick fd8f42d for a backport to 3.14

Don't ignore errors raised by PyErr_WarnFormat in warn_about_fork_with_threads Instead, ignore the warnings in all test code that forks. (That's a lot of functions.)

In test_support, make ignore_warnings a context manager (as well as decorator), and add a message argument to it.
Also add a ignore_fork_in_thread_deprecation_warnings helper for the deadlock-in-fork warning.

…ds with -Werror (pythonGH-136796)

Don't ignore errors raised by `PyErr_WarnFormat` in `warn_about_fork_with_threads`
Instead, ignore the warnings in all test code that forks. (That's a lot of functions.)

In `test_support`, make `ignore_warnings` a context manager (as well as decorator),
and add a `message` argument to it.
Also add a `ignore_fork_in_thread_deprecation_warnings` helper for the deadlock-in-fork
warning.
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @gpshead for commit b02aefc 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F140191%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 16, 2025
@encukou
Copy link
Member

encukou commented Oct 16, 2025

Should we backport this?

Warnings changes in patch releases make it harder to update, and from comments like #135427 (comment) it sounds like it's important to fix this now.

But, if you think it should get a backport, let's do it :)

@gpshead
Copy link
Member Author

gpshead commented Oct 17, 2025

I don't think this one is actually urgent to backport. I'll close this, the PR is ready and can be resurrected if deemed important.

So -Werror doesn't turn it into an error in 3.14 but we've fixed that in 3.15? good enough. This is an odd warning - it'll probably never become an error because our detection can only ever be best effort (it cannot be guaranteed to detect if other threads exist), it's more of the best way to surface an application design flaw to users.

@gpshead gpshead closed this Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants