gh-140138: NOGIL: add atomic owner refcount to PyInterpreterState; finalize on last tstate #140224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashm-dev
requested review from
ZeroIntensity and
ericsnowcurrently
as code owners
|
Changes made on top of the previous fix from PR |
Misc/NEWS.d/next/Core_and_Builtins/2025-10-16-20-06-33.gh-issue-140138.a_fhrh.rst
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Thanks, this PR looks good if we decide to fix this, but I'm worried about whether this is even a bug in the first place. See my comment on the issue. Please let me know if I missed something in my analysis.
Move the `_owners` field to be after `finalizing` and add it back to the struct. It was removed in a previous commit and is needed.
Fixes a typo where the atomic variable `_owners` was incorrectly named and should have been `owners`.
Rename functions to be more descriptive of their actions.
Move the cleanup logic into PyInterpreterState_Delete and remove the now-unused helper function.
The field name was inconsistent with other usages.
|
@ZeroIntensity this PR necessary or is it better to close it? |
|
I don't think this PR is necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.