gh-101525: Check whether to skip functions with computed gotos during BOLT runs #140250
+53
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed gotos, to BOLT skip list When building with --with-lto, --enable-bolt and --enable-shared, GCC creates optimized function clones with the suffix .lto_priv.0. The sre_ucs*_match functions use computed gotos, which BOLT cannot optimize, so their .lto_priv.0 clones must be skipped as well. Static builds and Clang's LTO implementation are not affected.
…during BOLT runs With LLVM >= 21.1.0 BOLT can handle computed gotos in PIC compiled code. Check for the LLVM version during configure to determine if we can safely skip those functions.
stratakis
requested review from
AA-Turner,
corona10,
emmatyping and
erlend-aasland
as code owners
7 tasks
|
With GCC when the -pack-relative-relocs linker flag is used, BOLT fails again on the same functions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With LLVM >= 21.1.0 BOLT can handle computed gotos in PIC compiled code.
Check for the LLVM version during configure to determine if we can safely skip those functions.
This PR builds on top of #139840