Skip to content

Conversation

@davep
Copy link

@davep davep commented Oct 17, 2025

@bedevere-app
Copy link

bedevere-app bot commented Oct 17, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@davep davep marked this pull request as ready for review October 17, 2025 15:45
@sergey-miryanov
Copy link
Contributor

Code looks good to me.
cc @markshannon @JelleZijlstra

@efimov-mikhail
Copy link
Member

efimov-mikhail commented Oct 17, 2025

This fix looks correct, but I doubt about the need of two always equal values in this case.

@davep
Copy link
Author

davep commented Oct 17, 2025

@efimov-mikhail Are you referring to the output of dis.dis here? Would that now ideally be changed as part of this PR?

@python-cla-bot
Copy link

python-cla-bot bot commented Oct 17, 2025

All commit authors signed the Contributor License Agreement.

CLA signed

@efimov-mikhail
Copy link
Member

Maybe we could add something like this if instr.argrepr and instr.argrepr != str(instr.arg)
to Formatter.print_instruction_line. But I want to hear another opinions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LOAD_SMALL_INT has empty argrepr via Bytecode

4 participants