Skip to content

gh-140257: fix data race on eval_breaker during finalization #140265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 18, 2025
Merged

gh-140257: fix data race on eval_breaker during finalization #140265

merged 3 commits into from
Oct 18, 2025

Conversation

@ashm-dev
Copy link
Contributor

@ashm-dev ashm-dev commented Oct 17, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Oct 17, 2025
Closed
colesbury
colesbury reviewed Oct 17, 2025
View reviewed changes
Copy link
Contributor

@colesbury colesbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, minor suggestion on comment including reference to issue

@colesbury colesbury added the needs backport to 3.14 bugs and security fixes label Oct 17, 2025
@ashm-dev @colesbury
Update Python/pystate.c
059570c 
Co-authored-by: Sam Gross <colesbury@gmail.com>
@ashm-dev ashm-dev requested a review from colesbury October 17, 2025 17:57
@kumaraditya303 kumaraditya303 merged commit c8729c9 into python:main Oct 18, 2025
49 checks passed
@miss-islington-app
Copy link

Thanks @ashm-dev for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 18, 2025
@ashm-dev @miss-islington
pythongh-140257: fix data race on eval_breaker during finalization (p…
f864c6c 
…ythonGH-140265)

(cherry picked from commit c8729c9)

Co-authored-by: Shamil <ashm.tech@proton.me>
@bedevere-app
Copy link

bedevere-app bot commented Oct 18, 2025

GH-140294 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Oct 18, 2025
kumaraditya303 pushed a commit that referenced this pull request Oct 18, 2025
@miss-islington @ashm-dev
[3.14] gh-140257: fix data race on eval_breaker during finalization (G…
3ca7ea1 
…H-140265) (#140294)

gh-140257: fix data race on eval_breaker during finalization (GH-140265)
(cherry picked from commit c8729c9)

Co-authored-by: Shamil <ashm.tech@proton.me>
@ashm-dev ashm-dev deleted the gh-140257 branch October 19, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesbury colesbury colesbury approved these changes

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@ZeroIntensity ZeroIntensity Awaiting requested review from ZeroIntensity ZeroIntensity is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ashm-dev @colesbury @kumaraditya303