- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 33.3k
gh-140438: Properly run the asyncio REPL in REPL tests #140298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-140438: Properly run the asyncio REPL in REPL tests #140298
Conversation
| I think it would be good if you created an issue for this. | 
| 
 @ZeroIntensity done; let's remove the  | 
| cc @asvetlov | 
| @kumaraditya303 is our primary asyncio maintainer at the moment. Kumar, are you familiar enough with the asyncio REPL to review this? | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| Thanks @bswck for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. | 
(cherry picked from commit 1a3da2c) Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
(cherry picked from commit 1a3da2c) Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
| GH-140507 is a backport of this pull request to the 3.14 branch. | 
| GH-140508 is a backport of this pull request to the 3.13 branch. | 
| 
 | 
Mixing
-iwith-m asynciofirst spawns the asyncio REPL. After asyncio REPL exits, it spawns the regular Python REPL.Here we're introducing more idiomatic way to test other custom REPLs in
test_replas necessary, without needing a pseudo-terminal.CC @ZeroIntensity (mentorship):
skip issue,skip news,needs backport to 3.13,needs backport to 3.14.-iflag is mixed with custom REPLs in tests #140438