gh-140482: Add some code to help debug the broken echo annoyance #140480
Conversation
| _runtest(result, runtests) | ||
| try: | ||
| attrs = termios.tcgetattr(sys.__stdin__.fileno()) | ||
| lflags = attrs[3] |
There was a problem hiding this comment.
I'm only abstractly aware of what you're checking here, but it makes me wonder if we can/should add this as an environment marker. Implementing this there might be better at pinpointing where things are going wrong (and also automatically restore things for you, if implemented correctly).
There was a problem hiding this comment.
I'm only abstractly aware of what you're checking here, but it makes me wonder if we can/should add this as an environment marker. Implementing this there might be better at pinpointing where things are going wrong (and also automatically restore things for you, if implemented correctly).
Yeah, that's an interesting idea I might explore when I get a little more time. I've also vaguely thought it would be kind of cool if you could set something to run some arbitrary code around each test, but that would take more design and discussion.
There was a problem hiding this comment.
@zware I like this suggestion so much, I'm going to refocus this PR to do exactly that. My remote got messed up so either I'll resolve the conflicts or just start over with a new PR, but either way, local testing solves the problem nicely. I think my debugging efforts were unsuccessful because more than one test can actually leave the tty in a -echo state. I'm not going to spend the time to dig into those root causes, but the env save/restore wfm.
Along those lines, I wish regrtest gave me a little more information about which tests changed the env in its test summary. Scrolling up I can see things like test_foo failed (env changed) and then the test gets rerun and succeeds, and I see things like this, which is helpful:
Warning -- stty_echo was modified by test_difflib
Warning -- Before: True
Warning -- After: False
but it would be nice if the summary, um, summarized these! Maybe that's implied in the 11 re-run tests section. That's a PR for another day.
== Tests result: ENV CHANGED then SUCCESS ==
10 slowest tests:
- test_signal: 44.2 sec
- test_xmlrpc: 27.3 sec
- test_logging: 23.2 sec
- test_remote_pdb: 21.6 sec
- test_ssl: 19.5 sec
- test_faulthandler: 18.3 sec
- test_selectors: 15.1 sec
- test_threading: 14.9 sec
- test.test_asyncio.test_tasks: 13.3 sec
- test_urllib2net: 13.0 sec
20 tests skipped:
test.test_asyncio.test_windows_events
test.test_asyncio.test_windows_utils test.test_gdb.test_backtrace
test.test_gdb.test_cfunction test.test_gdb.test_cfunction_full
test.test_gdb.test_misc test.test_gdb.test_pretty_print
test.test_os.test_windows test_android test_devpoll test_epoll
test_free_threading test_launcher test_msvcrt test_startfile
test_winapi test_winconsoleio test_winreg test_winsound test_wmi
2 tests skipped (resource denied):
test_peg_generator test_zipfile64
11 re-run tests:
test.test_asyncio.test_protocols test_configparser test_ctypes
test_difflib test_doctest test_locale test_math test_pickle
test_struct test_ttk test_zipimport
433 tests OK.
Total duration: 48.2 sec
Total tests: run=47,122 skipped=1,955
Total test files: run=464/455 skipped=20 resource_denied=2 rerun=11
Result: ENV CHANGED then SUCCESS
StanFromIreland
changed the title
|
Closing this draft in favor of !140519 |
There was a problem hiding this comment.
I need help everything is closed out
3 participants
Uh oh!
There was an error while loading. Please reload this page.