Skip to content

Conversation

@F18-Maverick
Copy link
Contributor

@F18-Maverick F18-Maverick commented Oct 24, 2025

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels Oct 24, 2025
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs Oct 24, 2025
@StanFromIreland StanFromIreland changed the title “skip issue” Add explanation for PyBool_Check func in bool.rst Add explanation for PyBool_Check func in bool.rst Oct 24, 2025
@StanFromIreland
Copy link
Member

Please don't add "skip issue" to the title, it only makes it more work for us. We will apply the label in due course.

@F18-Maverick
Copy link
Contributor Author

Please don't add "skip issue" to the title, it only makes it more work for us. We will apply the label in due course.

Okay, I'm so sory.

Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is useful. We already say "return true", which usually implies that the opposite is "return false".

@bedevere-app
Copy link

bedevere-app bot commented Oct 24, 2025

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Return true if *o* is of type :c:data:`PyBool_Type`. This function always
succeeds.
succeeds and always returns a valid boolean value.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not understand why this comment is necessary, per the previous line, it always succeeds, therefore it returns an integer, which is a valid boolean value, it makes it redundant? Can you please elaborate as to why this is needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, maybe your true, It's truely unnecessary. Sory about that, I'll close the PR soon.

@StanFromIreland StanFromIreland added the pending The issue will be closed if no feedback is provided label Oct 24, 2025
@F18-Maverick F18-Maverick deleted the add-explanation-bool.rst branch October 24, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting changes docs Documentation in the Doc dir pending The issue will be closed if no feedback is provided skip issue skip news

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

3 participants