gh-140517: Fix leak in map_next in strict mode
#140543
Merged
+41
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
picnixz
reviewed
Oct 24, 2025
efimov-mikhail
requested review from
kumaraditya303,
picnixz and
sergey-miryanov
picnixz
approved these changes
Oct 24, 2025
kumaraditya303
approved these changes
Oct 24, 2025
|
Thanks @efimov-mikhail for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 24, 2025
(cherry picked from commit be5af99) Co-authored-by: Mikhail Efimov <efimov.mikhail@gmail.com>
|
GH-140554 is a backport of this pull request to the 3.14 branch. |
kumaraditya303
pushed a commit
that referenced
this pull request
Oct 24, 2025
|
Why not add a NEWS entry? This is a real user facing leak. |
Sorry, I didn't know that we add NEWS entry in such cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
map_nextin strict mode in case of error #140517