Skip to content

Conversation

@efimov-mikhail
Copy link
Member

@efimov-mikhail efimov-mikhail commented Oct 24, 2025

@@ -0,0 +1,4 @@
Fixed a refcount leak when iterating over the result of the
built-in ``map`` function. It was possible if input ``iterables``
have different lengths and ``strict`` is ``True``.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe 'and strict mode is on'?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or strict=True.

Or maybe rewrite the entry as:

Fixed a reference leak when iterating over the result of :func:`map` with ``strict=True`` when the input iterables have different lengths.

@JelleZijlstra?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good too!

…e-140517.cqun-K.rst

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@picnixz picnixz changed the title gh-140517: NEWS entry gh-140517: add missing NEWS entry Oct 24, 2025
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Will leave it open for a little bit in case Serhyi has feedback.

@serhiy-storchaka serhiy-storchaka changed the title gh-140517: add missing NEWS entry Add missing NEWS entry for gh-140517 Oct 24, 2025
@@ -0,0 +1,4 @@
Fixed a reference leak when iterating over the result of
:func:`map`. The leak could happen when input ``iterables``
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that *iterables* or without hightlighting would be better.

@@ -0,0 +1,4 @@
Fixed a refcount leak when iterating over the result of the
built-in ``map`` function. It was possible if input ``iterables``
have different lengths and ``strict`` is ``True``.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or strict=True.

Or maybe rewrite the entry as:

Fixed a reference leak when iterating over the result of :func:`map` with ``strict=True`` when the input iterables have different lengths.

@JelleZijlstra?

@efimov-mikhail
Copy link
Member Author

IMO, this suits better:

Fixed a reference leak when iterating over the result of :func:`map` with ``strict=True`` when the input iterables have different lengths.

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@serhiy-storchaka serhiy-storchaka merged commit d78d7a5 into python:main Oct 24, 2025
27 checks passed
@miss-islington-app
Copy link

Thanks @efimov-mikhail for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Oct 24, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 24, 2025
(cherry picked from commit d78d7a5)

Co-authored-by: Mikhail Efimov <efimov.mikhail@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Oct 24, 2025

GH-140565 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Oct 24, 2025
serhiy-storchaka pushed a commit that referenced this pull request Oct 24, 2025
(cherry picked from commit d78d7a5)

Co-authored-by: Mikhail Efimov <efimov.mikhail@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants