Skip to content

Conversation

@bitdancer
Copy link
Member

@bitdancer bitdancer commented Oct 28, 2025

This variable is not documented as part of the API in the standard
library documentation; it should be considered as an implementation
detail and as such should not be included in the doc string.

Closes #57665.

This variable is not documented as part of the API in the standard
library documentation; it should be considered as an implementation
detail and as such should not be included in the doc string.

Closes python#57665.
@bitdancer bitdancer self-assigned this Oct 28, 2025
@bitdancer bitdancer changed the title Remove 'response_class' from getresponse docstring. gh-57655: Remove 'response_class' from getresponse docstring. Oct 28, 2025
@bitdancer bitdancer changed the title gh-57655: Remove 'response_class' from getresponse docstring. gh-57665: Remove 'response_class' from getresponse docstring. Oct 28, 2025
Copy link
Member

@orsenthil orsenthil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The reasoning is fine.

@orsenthil orsenthil merged commit 81cec22 into python:main Oct 31, 2025
52 checks passed
@bitdancer bitdancer deleted the remove_response_class_from_doc_string-57665 branch October 31, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Providing a custom HTTPResponse class to HTTPConnection

2 participants