Skip to content

gh-140657: Don't rerun test_import single phase init test #140712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2025
Merged

gh-140657: Don't rerun test_import single phase init test #140712

merged 1 commit into from
Oct 28, 2025

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Oct 28, 2025 •
edited by bedevere-app bot
Loading

test_basic_multiple_interpreters_main_no_reset() leaks memory: import_in_subinterp() is called with postcleanup=False on purpose.

@vstinner
pythongh-140657: Don't rerun test_import single phase init test
efec437 
test_basic_multiple_interpreters_main_no_reset() leaks memory:
import_in_subinterp() is called with postcleanup=False on purpose.
@bedevere-app bedevere-app bot mentioned this pull request Oct 28, 2025
Closed
@vstinner
Copy link
Member Author

cc @encukou

@vstinner
Copy link
Member Author

This change does fix the issue #140657 (comment) on FreeBSD!

@vstinner vstinner mentioned this pull request Oct 28, 2025
Closed
@encukou encukou merged commit c6d4c79 into python:main Oct 28, 2025
48 checks passed
@vstinner vstinner deleted the test_import_no_rerun branch October 28, 2025 17:05
@vstinner vstinner added the needs backport to 3.14 bugs and security fixes label Oct 28, 2025
@miss-islington-app
Copy link

Thanks @vstinner for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 28, 2025
@vstinner @miss-islington
pythongh-140657: Don't rerun test_import single phase init test (pyth…
efa8e16 
…onGH-140712)

test_basic_multiple_interpreters_main_no_reset() leaks memory:
import_in_subinterp() is called with postcleanup=False.
(cherry picked from commit c6d4c79)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app
Copy link

bedevere-app bot commented Oct 28, 2025

GH-140713 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Oct 28, 2025
@vstinner vstinner added the needs backport to 3.13 bugs and security fixes label Oct 28, 2025
@miss-islington-app
Copy link

Thanks @vstinner for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 28, 2025
@vstinner @miss-islington
pythongh-140657: Don't rerun test_import single phase init test (pyth…
6252b3a 
…onGH-140712)

test_basic_multiple_interpreters_main_no_reset() leaks memory:
import_in_subinterp() is called with postcleanup=False.
(cherry picked from commit c6d4c79)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app
Copy link

bedevere-app bot commented Oct 28, 2025

GH-140714 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Oct 28, 2025
vstinner added a commit that referenced this pull request Oct 28, 2025
@miss-islington @vstinner
[3.13] gh-140657: Don't rerun test_import single phase init test (GH-…
a026f02 
…140712) (#140714)

gh-140657: Don't rerun test_import single phase init test (GH-140712)

test_basic_multiple_interpreters_main_no_reset() leaks memory:
import_in_subinterp() is called with postcleanup=False.
(cherry picked from commit c6d4c79)

Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner added a commit that referenced this pull request Oct 28, 2025
@miss-islington @vstinner
[3.14] gh-140657: Don't rerun test_import single phase init test (GH-…
6822b13 
…140712) (#140713)

gh-140657: Don't rerun test_import single phase init test (GH-140712)

test_basic_multiple_interpreters_main_no_reset() leaks memory:
import_in_subinterp() is called with postcleanup=False.
(cherry picked from commit c6d4c79)

Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vstinner @encukou