Skip to content

gh-140693: Improve argparse documentation about controlling color #140737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 2, 2025
Merged

gh-140693: Improve argparse documentation about controlling color #140737

merged 3 commits into from
Nov 2, 2025
+5 −0

Conversation

@XChaitanyaX
Copy link
Contributor

@XChaitanyaX XChaitanyaX commented Oct 29, 2025 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news labels Oct 29, 2025
@bedevere-app bedevere-app bot mentioned this pull request Oct 29, 2025
Closed
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs Oct 29, 2025
savannahostrowski
savannahostrowski requested changes Oct 29, 2025
View reviewed changes
Copy link
Member

@savannahostrowski savannahostrowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR for this! I have a suggestion for how we can keep things more concise.

@bedevere-app
Copy link

bedevere-app bot commented Oct 29, 2025

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@savannahostrowski savannahostrowski moved this from Todo to In Progress in Docs PRs Oct 29, 2025
@XChaitanyaX
Copy link
Contributor Author

I have made the requested changes; please review again.

@bedevere-app
Copy link

bedevere-app bot commented Oct 30, 2025

Thanks for making the requested changes!

@savannahostrowski: please review the changes made to this pull request.

savannahostrowski
savannahostrowski reviewed Oct 30, 2025
View reviewed changes
@savannahostrowski savannahostrowski added needs backport to 3.14 bugs and security fixes and removed needs backport to 3.14 bugs and security fixes labels Oct 30, 2025
@XChaitanyaX
Copy link
Contributor Author

Thanks for the review :)

I wrapped your suggestion to 79 chars...

savannahostrowski
savannahostrowski approved these changes Nov 2, 2025
View reviewed changes
Copy link
Member

@savannahostrowski savannahostrowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@savannahostrowski savannahostrowski merged commit 31de83d into python:main Nov 2, 2025
31 of 32 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Docs PRs Nov 2, 2025
@XChaitanyaX XChaitanyaX deleted the pr_140693 branch November 3, 2025 02:12
@XChaitanyaX
Copy link
Contributor Author

no backport to 3.14??

@savannahostrowski savannahostrowski added the needs backport to 3.14 bugs and security fixes label Nov 3, 2025
@miss-islington-app
Copy link

Thanks @XChaitanyaX for the PR, and @savannahostrowski for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 3, 2025
@XChaitanyaX @miss-islington
pythongh-140693: Improve argparse documentation about controlling c…
0c87dd6 
…olor (pythonGH-140737)

(cherry picked from commit 31de83d)

Co-authored-by: Krishna Chaitanya <141550576+XChaitanyaX@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Nov 3, 2025

GH-140932 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Nov 3, 2025
savannahostrowski pushed a commit that referenced this pull request Nov 3, 2025
@miss-islington @XChaitanyaX
[3.14] gh-140693: Improve argparse documentation about controlling …
fa9bb9a 
…color (GH-140737) (#140932)

gh-140693: Improve `argparse` documentation about controlling color (GH-140737)
(cherry picked from commit 31de83d)

Co-authored-by: Krishna Chaitanya <141550576+XChaitanyaX@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@savannahostrowski savannahostrowski savannahostrowski approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@XChaitanyaX @savannahostrowski