Skip to content

[3.13] gh-140551: Fix dict crash if clear is called at lookup stage (GH-140558) #140744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 30, 2025
Merged

[3.13] gh-140551: Fix dict crash if clear is called at lookup stage (GH-140558) #140744

merged 2 commits into from
Oct 30, 2025

Conversation

@efimov-mikhail
Copy link
Member

@efimov-mikhail efimov-mikhail commented Oct 29, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Oct 29, 2025
Closed
@bedevere-app bedevere-app bot mentioned this pull request Oct 29, 2025
Merged
@efimov-mikhail @methane
pythongh-140551: Fix dict crash if clear is called at lookup st…
2ece07d 
…age (python#140558)

Co-authored-by: Inada Naoki <songofacandy@gmail.com>
@efimov-mikhail
Copy link
Member Author

efimov-mikhail commented Oct 29, 2025 •
edited
Loading

We can't merge this now.
I've reproduced CI fail of test.test_io.PyIOTest.test_garbage_collection on my machine with TSAN.

@efimov-mikhail
Copy link
Member Author

efimov-mikhail commented Oct 29, 2025 •
edited
Loading

With the last change CI is green and I think we can merge it.

@kumaraditya303 kumaraditya303 merged commit eec9257 into python:3.13 Oct 30, 2025
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@methane methane methane approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@efimov-mikhail @methane @kumaraditya303