Skip to content

GH-140768: Warn when the WASI SDK version doesn't match the supported version #140769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 30, 2025
Merged

GH-140768: Warn when the WASI SDK version doesn't match the supported version #140769

merged 2 commits into from
Oct 30, 2025

Conversation

@brettcannon
Copy link
Member

@brettcannon brettcannon commented Oct 29, 2025 •
edited by bedevere-app bot
Loading

@brettcannon brettcannon self-assigned this Oct 29, 2025
@bedevere-app bedevere-app bot mentioned this pull request Oct 29, 2025
Closed
@brettcannon brettcannon added the needs backport to 3.14 bugs and security fixes label Oct 29, 2025
@brettcannon brettcannon reopened this Oct 29, 2025
@brettcannon
Copy link
Member Author

All the pertinent checks passed, but it still got flagged as failing (I think some CI tests got cancelled by GitHub for some reason).

emmatyping
emmatyping approved these changes Oct 29, 2025
View reviewed changes
Copy link
Member

@emmatyping emmatyping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. The only question I have is should we warn if the version file is not present since that implies the version is <25?

savannahostrowski
savannahostrowski approved these changes Oct 30, 2025
View reviewed changes
@brettcannon
Copy link
Member Author

This looks good. The only question I have is should we warn if the version file is not present since that implies the version is <25?

Technically we could (and I originally did), but I also didn't want to care if for some reason someone deleted the file. Basically it seemed marginal enough of a possibility I didn't want to add even more logic.

@brettcannon brettcannon merged commit 95a3564 into python:main Oct 30, 2025
50 checks passed
@brettcannon brettcannon deleted the warn-if-wasi-sdk-does-not-match branch October 30, 2025 16:32
@miss-islington-app
Copy link

Thanks @brettcannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 30, 2025
@brettcannon @miss-islington
pythonGH-140768: Warn when the WASI SDK version doesn't match the sup…
e2e5c54 
…ported version (pythonGH-140769)

(cherry picked from commit 95a3564)

Co-authored-by: Brett Cannon <brett@python.org>
@bedevere-app
Copy link

bedevere-app bot commented Oct 30, 2025

GH-140801 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Oct 30, 2025
brettcannon added a commit that referenced this pull request Oct 30, 2025
@miss-islington @brettcannon
[3.14] GH-140768: Warn when the WASI SDK version doesn't match the su…
e595d99 
…pported version (GH-140769) (GH-140801)

GH-140768: Warn when the WASI SDK version doesn't match the supported version (GH-140769)
(cherry picked from commit 95a3564)

Co-authored-by: Brett Cannon <brett@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@savannahostrowski savannahostrowski savannahostrowski approved these changes

@emmatyping emmatyping emmatyping approved these changes

@mdboom mdboom Awaiting requested review from mdboom

Assignees

@brettcannon brettcannon

Labels

OS-wasi

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brettcannon @savannahostrowski @emmatyping