gh-137821: Improve Argument Clinic definitions in the _json module
#140780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
corona10
commented
Oct 30, 2025
| @@ -0,0 +1,2 @@ | |||
| Convert ``_json`` module to use Argument Clinic. | |||
corona10
commented
Oct 30, 2025
corona10
changed the title
corona10
changed the title
corona10
commented
Oct 30, 2025
| def test_overflow(self): | ||
| with self.assertRaises(OverflowError): | ||
| self.json.decoder.scanstring(b"xxx", sys.maxsize+1) | ||
| self.json.decoder.scanstring("xxx", sys.maxsize+1) |
Member
Author
There was a problem hiding this comment.
This was wrongly tested.
Member
Author
There was a problem hiding this comment.
See:
Python 3.11.6 (v3.11.6:8b6ee5ba3b, Oct 2 2023, 11:18:21) [Clang 13.0.0 (clang-1300.0.29.30)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import json
>>> json.decoder.scanstring(b"xxx", 10)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
TypeError: first argument must be a string, not bytes
StanFromIreland
approved these changes
Oct 30, 2025
corona10
changed the title
_json module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_jsonto Argument Clinic #137821