gh-140870: PyREPL auto-complete module attributes in import statements #140871
+290
−26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability for
_pyrepl._module_completer.ModuleCompleterto suggest attributes, in addition to modules.If the module to import from is not imported yet, ask the user if they want to import it.
This is done by adding the notion of completion action to
_pyrepl.completing_reader.CompletingReader:get_completionscan return a completion action, in addtion to the suggestions listget_completionsis called again, so it can propose new results (here, module attributes)Other changes:
_module_completerto 100% (in a separate commit, I can remove it if needed)Interactive WebAssembly demo (up to date): https://pyrepl-attributes-import-completion.pages.dev
Possible improvement (probably in a follow-up PR): make modules printing stuff when imported not mess with the prompt ; see this Discourse message