Skip to content

gh-133600: Run Tools/wasm/wasi on CI instead of deprecated Tools/wasm/wasi.py #140907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2025
Merged

gh-133600: Run Tools/wasm/wasi on CI instead of deprecated Tools/wasm/wasi.py #140907

merged 1 commit into from
Nov 3, 2025

Conversation

@hugovk
Copy link
Member

@hugovk hugovk commented Nov 2, 2025 •
edited by bedevere-app bot
Loading

To avoid the deprecation warning in logs:

⚠️ WARNING: This script is deprecated and slated for removal in Python 3.20; execute the `wasi/` directory instead (i.e. `python Tools/wasm/wasi`)

And also use the correct __main__.py file for the cache key.

cc codeowners of Tools/wasm/wasi @brettcannon @emmatyping

@hugovk hugovk requested a review from ezio-melotti as a code owner November 2, 2025 10:56
@hugovk hugovk added the infra CI, GitHub Actions, buildbots, Dependabot, etc. label Nov 2, 2025
@hugovk hugovk requested a review from AA-Turner as a code owner November 2, 2025 10:56
@hugovk hugovk added the needs backport to 3.14 bugs and security fixes label Nov 2, 2025
@hugovk hugovk changed the title Run Tools/wasm/wasi on CI instead of deprecated Tools/wasm/wasi.py gh-133600: Run Tools/wasm/wasi on CI instead of deprecated Tools/wasm/wasi.py Nov 2, 2025
@hugovk hugovk removed the skip issue label Nov 2, 2025
@bedevere-app bedevere-app bot mentioned this pull request Nov 2, 2025
Closed
emmatyping
emmatyping approved these changes Nov 2, 2025
View reviewed changes
Copy link
Member

@emmatyping emmatyping left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think these changes look good!

@hugovk hugovk merged commit cf1a2c1 into python:main Nov 3, 2025
60 checks passed
@hugovk hugovk deleted the 3.15-wasi.py-to-wasi branch November 3, 2025 19:26
@miss-islington-app
Copy link

miss-islington-app bot commented Nov 3, 2025

Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 3, 2025
@hugovk @miss-islington
pythongh-133600: Run Tools/wasm/wasi on CI instead of deprecated `T…
afbb474 
…ools/wasm/wasi.py` (pythonGH-140907)

(cherry picked from commit cf1a2c1)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Nov 3, 2025

GH-140964 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Nov 3, 2025
hugovk added a commit that referenced this pull request Nov 3, 2025
@miss-islington @hugovk
[3.14] gh-133600: Run Tools/wasm/wasi on CI instead of deprecated `…
894b528 
…Tools/wasm/wasi.py` (GH-140907) (#140964)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emmatyping emmatyping emmatyping approved these changes

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Assignees

No one assigned

Labels

infra CI, GitHub Actions, buildbots, Dependabot, etc. skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hugovk @emmatyping