Skip to content

gh-118516: clarify that subprocess are automatically killed if transport gets garbage collected #140997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2025
Merged

gh-118516: clarify that subprocess are automatically killed if transport gets garbage collected #140997

merged 1 commit into from
Nov 6, 2025

Conversation

@kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Nov 4, 2025 •
edited by github-actions bot
Loading

This documents the asyncio's behavior of killing the subprocess if the transport is closed or gets garbage collected.
This behaviour is tested at

cpython/Lib/test/test_asyncio/test_subprocess.py

Line 563 in fa9c3ee

def test_close_kill_running(self):

📚 Documentation preview 📚: https://cpython-previews--140997.org.readthedocs.build/

@kumaraditya303 kumaraditya303 added the docs Documentation in the Doc dir label Nov 4, 2025
@kumaraditya303 kumaraditya303 added the needs backport to 3.14 bugs and security fixes label Nov 4, 2025
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs Nov 4, 2025
@bedevere-app bedevere-app bot mentioned this pull request Nov 4, 2025
Closed
@kumaraditya303 kumaraditya303 merged commit 101c9c0 into python:main Nov 6, 2025
41 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Nov 6, 2025
@miss-islington-app
Copy link

miss-islington-app bot commented Nov 6, 2025

Thanks @kumaraditya303 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 6, 2025
@kumaraditya303 @miss-islington
pythongh-118516: clarify that subprocess are automatically killed if …
c3713cd 
…transport gets garbage collected (pythonGH-140997)

(cherry picked from commit 101c9c0)

Co-authored-by: Kumar Aditya <kumaraditya@python.org>
@bedevere-app
Copy link

bedevere-app bot commented Nov 6, 2025

GH-141110 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Nov 6, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 6, 2025
@kumaraditya303 @miss-islington
pythongh-118516: clarify that subprocess are automatically killed if …
53b48be 
…transport gets garbage collected (pythonGH-140997)

(cherry picked from commit 101c9c0)

Co-authored-by: Kumar Aditya <kumaraditya@python.org>
@bedevere-app
Copy link

bedevere-app bot commented Nov 6, 2025

GH-141111 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Nov 6, 2025
@kumaraditya303 kumaraditya303 deleted the asyncio-subprocess-docs-tests branch November 6, 2025 04:51
kumaraditya303 added a commit that referenced this pull request Nov 6, 2025
@miss-islington @kumaraditya303
[3.14] gh-118516: clarify that subprocess are automatically killed if…
9878611 
… transport gets garbage collected (GH-140997) (#141110)

gh-118516: clarify that subprocess are automatically killed if transport gets garbage collected (GH-140997)
(cherry picked from commit 101c9c0)

Co-authored-by: Kumar Aditya <kumaraditya@python.org>
kumaraditya303 added a commit that referenced this pull request Nov 6, 2025
@miss-islington @kumaraditya303
[3.13] gh-118516: clarify that subprocess are automatically killed if…
8641c47 
… transport gets garbage collected (GH-140997) (#141111)

gh-118516: clarify that subprocess are automatically killed if transport gets garbage collected (GH-140997)
(cherry picked from commit 101c9c0)

Co-authored-by: Kumar Aditya <kumaraditya@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@willingc willingc Awaiting requested review from willingc willingc is a code owner

@gpshead gpshead Awaiting requested review from gpshead

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news topic-asyncio

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kumaraditya303