gh-141150: Don't rely on implicit conversion from void * to pointer in _PyModule… #141147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DinoV
changed the title
beneltayar
pushed a commit
to beneltayar/cpython
that referenced
this pull request
Nov 6, 2025
…nter in _PyModule… (python#141147) Don't rely on implicit conversion from void * to pointer in _PyModule_GetToken
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_PyModule_GetTokenrelies upon an implicit conversion from a void* toPyModuleDef *. This is totally legal but the explicit cast is a little bit better. FYI we saw this where we include this in Cinder from a C++ file.