Skip to content

gh-138890: Better way to clear name error suggestion #141389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Locked-chess-official wants to merge 2 commits into
base: main
Choose a base branch
from
Open

gh-138890: Better way to clear name error suggestion #141389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ac39e1
clear builtins in suggestion when deleting
Locked-chess-official Nov 11, 2025
d16cb29
add News
Locked-chess-official Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Lib/traceback.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
import tokenize
import io
import _colorize
import dis

from contextlib import suppress

Expand Down Expand Up @@ -1677,8 +1678,9 @@ def _compute_suggestion_error(exc_value, tb, wrong_name):
d = (
list(frame.f_locals)
+ list(frame.f_globals)
+ list(frame.f_builtins)
)
if not dis.opname[frame.f_code.co_code[frame.f_lasti]].startswith('DELETE_'):
d += list(frame.f_builtins)
d = [x for x in d if isinstance(x, str)]

# Check first if we are in a method and the instance
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Core_and_Builtins/2025-11-11-14-21-33.gh-issue-138890.QwN0EU.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Use a more simple way to forbidden the builtins name suggestion in deleting
Loading