Skip to content

gh-141376: Remove exceptions from make smelly #141392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 14, 2025
Merged

gh-141376: Remove exceptions from make smelly #141392

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
008ffb7
gh-141376: make smelly: Don't ignore initialized data and BSS
encukou Nov 11, 2025
6158bf2
Remove exceptions for _init and _fini
encukou Nov 11, 2025
69667d4
Remove outdated/misplaced comments
encukou Nov 11, 2025
1112f19
Merge branch 'main' into smelly-data
encukou Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions Tools/build/smelly.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@
})

IGNORED_EXTENSION = "_ctypes_test"
# Ignore constructor and destructor functions
IGNORED_SYMBOLS = {'_init', '_fini'}


def is_local_symbol_type(symtype):
Expand All @@ -34,19 +32,12 @@ def is_local_symbol_type(symtype):
if symtype.islower() and symtype not in "uvw":
return True

# Ignore the initialized data section (d and D) and the BSS data
# section. For example, ignore "__bss_start (type: B)"
# and "_edata (type: D)".
if symtype in "bBdD":
return True

return False


def get_exported_symbols(library, dynamic=False):
print(f"Check that {library} only exports symbols starting with Py or _Py")

# Only look at dynamic symbols
args = ['nm', '--no-sort']
if dynamic:
args.append('--dynamic')
Expand Down Expand Up @@ -89,8 +80,6 @@ def get_smelly_symbols(stdout, dynamic=False):

if is_local_symbol_type(symtype):
local_symbols.append(result)
elif symbol in IGNORED_SYMBOLS:
local_symbols.append(result)
else:
smelly_symbols.append(result)

Expand Down
Loading