-
-
Notifications
You must be signed in to change notification settings - Fork 33.4k
gh-132657: Add regression test for PySet_Contains #141411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
As discussed in pythongh-141183, the test suite did not test that PySet_Contains does not convert unhashable key into a frozenset. This commit adds a regression test for this behavior, to ensure that any behavior change is caught by the test suite.
3434a3d to
9d02192
Compare
|
You need to call the function as well no? Check |
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
It's called in |
|
Thanks @Carreau for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Thanks @Carreau for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
…able type (pythonGH-141411) (cherry picked from commit 2ac738d) Co-authored-by: M Bussonnier <bussonniermatthias@gmail.com>
|
GH-141467 is a backport of this pull request to the 3.13 branch. |
…able type (pythonGH-141411) (cherry picked from commit 2ac738d) Co-authored-by: M Bussonnier <bussonniermatthias@gmail.com>
|
GH-141468 is a backport of this pull request to the 3.14 branch. |
|
Thanks! |
|
|
|
Thanks ! |
As discussed in gh-141183, the test suite did not
test that
PySet_Containsdoes not convert unhashable key into a frozenset.This commit adds a regression test for this
behavior, to ensure that any behavior change is
caught by the test suite.
--
I'm not sure opening a GitHub issue, or having a blurb is necessary as this only adds a test.
Here is the link to the comment where @kumaraditya303 suggested for me to send a test as a separate PR.