gh-141415: Remove unused variables and comment in _pyrepl.windows_console.py
#141416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanloong
requested review from
ambv,
lysnikolaou and
pablogsal
as code owners
Misc/NEWS.d/next/Library/2025-11-12-00-45-35.gh-issue-141415.I_sVyA.rst
Outdated
Show resolved
Hide resolved
This reverts commit 3ce7688.
pablogsal
approved these changes
Nov 11, 2025
Member
|
Thanks for the PR @tanloong |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the unused
px_pos,self.__gone_talland comment from_pyrepl.windows_console.py.After
px_posis removed, thepx_coordparameter of__write_changed_linealso becomes unused, which in turn makes an access toself.posxyunused as well. I didn't remove these two parts as I'm not sure if there are any concerns about changing the function signature of__write_changed_line(),_pyrepl.windows_console.py#141415