gh-141579: Fix perf_jit backend in sys.activate_stack_trampoline() #141580
+28
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The perf_jit backend was unreachable due to incorrect if-else nesting in the backend selection logic. The else-if checking for "perf_jit" was nested inside the if statement checking for "perf", making it impossible to activate the perf_jit trampoline.
pablogsal
added
needs backport to 3.13
Contributor
|
Probably need to re-run the iOS test |
|
Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 15, 2025
…e() (pythonGH-141580) (cherry picked from commit 4ceb077c5cea30fef734f4c4e92c18d978be6c38) Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
|
Sorry, @pablogsal, I could not cleanly backport this to |
|
GH-141581 is a backport of this pull request to the 3.14 branch. |
Contributor
|
Fun with git... @pablogsal |
|
GH-141582 is a backport of this pull request to the 3.13 branch. |
pablogsal
added a commit
to pablogsal/cpython
that referenced
this pull request
Nov 15, 2025
…ampoline() (pythonGH-141580) (cherry picked from commit 4ceb077) Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
pablogsal
added a commit
that referenced
this pull request
Nov 15, 2025
pablogsal
added a commit
that referenced
this pull request
Nov 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The perf_jit backend was unreachable due to incorrect if-else nesting
in the backend selection logic. The else-if checking for "perf_jit"
was nested inside the if statement checking for "perf", making it
impossible to activate the perf_jit trampoline.