Skip to content

gh-141612: Tests: Add missing assertions to test_trampoline_works_with_forks #141613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
+10 −0
Open

gh-141612: Tests: Add missing assertions to test_trampoline_works_with_forks #141613

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ca4c20a
Tests: Add missing assertions to test_trampoline_works_with_forks
pareshjoshij Nov 16, 2025
16774c4
Update Lib/test/test_perf_profiler.py
pareshjoshij Nov 17, 2025
fcf64ff
Update Lib/test/test_perf_profiler.py
pareshjoshij Nov 17, 2025
fa941aa
Merge branch 'main' into fix-perf-test-assertions
pareshjoshij Nov 17, 2025
d478e05
Enhance performance profiler tests
pareshjoshij Nov 17, 2025
d1bb7e4
Minimize diff: remove negative assertions
pareshjoshij Nov 17, 2025
2e58457
Update Lib/test/test_perf_profiler.py
efimov-mikhail Nov 17, 2025
399ea53
Fix formatting in test_perf_profiler.py
pareshjoshij Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions Lib/test/test_perf_profiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,16 @@ def baz():
self.assertIn(f"py::bar_fork:{script}", child_perf_file_contents)
self.assertIn(f"py::baz_fork:{script}", child_perf_file_contents)

# The parent's map should not contain the child's symbols
self.assertNotIn(f"py::foo_fork:{script}", perf_file_contents)
self.assertNotIn(f"py::bar_fork:{script}", perf_file_contents)
self.assertNotIn(f"py::baz_fork:{script}", perf_file_contents)

# The child's map should not contain the parent's symbols
self.assertNotIn(f"py::foo:{script}", child_perf_file_contents)
self.assertNotIn(f"py::bar:{script}", child_perf_file_contents)
self.assertNotIn(f"py::baz:{script}", child_perf_file_contents)

@unittest.skipIf(support.check_bolt_optimized(), "fails on BOLT instrumented binaries")
def test_sys_api(self):
for define_eval_hook in (False, True):
Expand Down
Loading