Skip to content

Conversation

@alexcrichton
Copy link
Contributor

@alexcrichton alexcrichton commented Nov 17, 2025

This commit updates CI and configuration from wasi-sdk-25 to wasi-sdk-29 which was released recently. This notably includes stubs for pthreads which all return errors, so some adjustment in logic is necessary to retain knowledge that WASI cannot yet spawn threads for example.

This additionally increases the wasm stack allowance to 32MiB from 16MiB to accomodate the test_recursive_pickle test in teh test_functools.py file. It looks like the Clang/LLVM update that happened in wasi-sdk-29 relative to wasi-sdk-25 is likely the cause of this where presumably functions have more locals than before and/or a slightly adjusted stack space requirement which overflows the stack.

cc @brettcannon

This commit updates CI and configuration from wasi-sdk-25 to wasi-sdk-29
which was released recently. This notably includes stubs for pthreads
which all return errors, so some adjustment in logic is necessary to
retain knowledge that WASI cannot yet spawn threads for example.

This additionally increases the wasm stack allowance to 32MiB from 16MiB
to accomodate the `test_recursive_pickle` test in teh
`test_functools.py` file. It looks like the Clang/LLVM update that
happened in wasi-sdk-29 relative to wasi-sdk-25 is likely the cause of
this where presumably functions have more locals than before and/or a
slightly adjusted stack space requirement which overflows the stack.
@python-cla-bot
Copy link

python-cla-bot bot commented Nov 17, 2025

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Nov 17, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@hugovk hugovk added skip news infra CI, GitHub Actions, buildbots, Dependabot, etc. labels Nov 18, 2025
Copy link
Member

@brettcannon brettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you create a news entry for this? Otherwise it LGTM!

@bedevere-app
Copy link

bedevere-app bot commented Nov 18, 2025

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@hugovk hugovk removed the skip news label Nov 19, 2025
@bedevere-app
Copy link

bedevere-app bot commented Nov 19, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@alexcrichton
Copy link
Contributor Author

I have made the requested changes; please review again

Happy to expand as well, I wasn't sure how much needs to be mentioned other than an update happened

@bedevere-app
Copy link

bedevere-app bot commented Nov 19, 2025

Thanks for making the requested changes!

@brettcannon: please review the changes made to this pull request.

@bedevere-app bedevere-app bot requested a review from brettcannon November 19, 2025 17:23
@brettcannon brettcannon merged commit 9b69a55 into python:main Nov 19, 2025
51 of 54 checks passed
@brettcannon
Copy link
Member

Thanks!

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot wasm32-wasi 3.x (tier-2) has failed when building commit 9b69a55.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1046/builds/10237) and take a look at the build logs.
  4. Check if the failure is related to this commit (9b69a55) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1046/builds/10237

Failed tests:

  • test_sys

Failed subtests:

  • test_thread_info - test.test_sys.SysModuleTest.test_thread_info

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "/Lib/test/test_sys.py", line 734, in test_thread_info
    self.assertEqual(info.name, "pthread")
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'pthread-stubs' != 'pthread'
- pthread-stubs
+ pthread

@brettcannon
Copy link
Member

The failure is on the Buildbot side. I think if I make sure to install WASI SDK 29 on it then the issue will be resolved. Going to do that now.

@brettcannon
Copy link
Member

https://buildbot.python.org/all/#/builders/1046/builds/10238 picked up the new WASI SDK install on the Buildbot. I'm just waiting for the run to finish before declaring everything is okay.

@brettcannon
Copy link
Member

All good now!

@alexcrichton alexcrichton deleted the update-to-wasi-sdk-29 branch November 19, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infra CI, GitHub Actions, buildbots, Dependabot, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants