-
-
Notifications
You must be signed in to change notification settings - Fork 33.6k
gh-105836: Fix asyncio.run_coroutine_threadsafe leaving underlying cancelled asyncio task running #141696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+29
−2
Merged
gh-105836: Fix asyncio.run_coroutine_threadsafe leaving underlying cancelled asyncio task running #141696
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
f69f706
Fix gh-105836
iaalm 8fa2cac
Add unit test
iaalm 42f3885
Fix code style
iaalm 5398219
Revert test
iaalm d7675d3
Improve test case
iaalm f430392
Run test in another thread
iaalm 670e875
Use lock to make sure target started
iaalm f061b1d
Revert "Run test in another thread"
iaalm e5afb6d
Apply nits from code review
gvanrossum 6602b27
Apply style nits from code review
gvanrossum 3567e94
Too many blank lines (my fault)
gvanrossum 0598eed
Fix test for windows
iaalm 787c9fc
Fix white space
iaalm c97e497
improve test
kumaraditya303 e3a4011
Apply suggestion from @kumaraditya303
kumaraditya303 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
Misc/NEWS.d/next/Library/2025-11-18-15-48-13.gh-issue-105836.sbUw24.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| Fix :meth:`asyncio.run_coroutine_threadsafe` leaving underlying cancelled | ||
| asyncio task running. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.