Skip to content

gh-141784: Fix _remote_debugging_module.c compilation on 32-bit Linux #141796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2025
Merged

gh-141784: Fix _remote_debugging_module.c compilation on 32-bit Linux #141796

merged 1 commit into from
Nov 20, 2025

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Nov 20, 2025 •
edited by bedevere-app bot
Loading

Include Python.h before system headers to make sure that _remote_debugging_module.c uses the same types (ABI) than Python.

@bedevere-app bedevere-app bot mentioned this pull request Nov 20, 2025
Closed
@vstinner
pythongh-141784: Fix _remote_debugging_module.c compilation on 32-bit…
7a0e1e4 
… Linux

Include Python.h before system headers to make sure that
_remote_debugging_module.c uses the same types (ABI) than Python.
@vstinner vstinner added the needs backport to 3.14 bugs and security fixes label Nov 20, 2025
@vstinner vstinner enabled auto-merge (squash) November 20, 2025 16:24
@vstinner vstinner merged commit 722f4bb into python:main Nov 20, 2025
52 checks passed
@vstinner vstinner deleted the remote_debugging branch November 20, 2025 16:30
@miss-islington-app
Copy link

miss-islington-app bot commented Nov 20, 2025

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

miss-islington-app bot commented Nov 20, 2025

Sorry, @vstinner, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 722f4bb8c9c6b32a7221e4813058cbb5c3989c10 3.14

@bedevere-app
Copy link

bedevere-app bot commented Nov 20, 2025

GH-141800 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Nov 20, 2025
vstinner added a commit to vstinner/cpython that referenced this pull request Nov 20, 2025
@vstinner
pythongh-141784: Fix _remote_debugging_module.c compilation on 32-bit…
10bb719 
… Linux (python#141796)

Include Python.h before system headers to make sure that
_remote_debugging_module.c uses the same types (ABI) than Python.

(cherry picked from commit 722f4bb)
@vstinner
Copy link
Member Author

vstinner commented Nov 20, 2025

Merged, thanks for the review @pablogsal.

vstinner added a commit that referenced this pull request Nov 20, 2025
@vstinner
[3.14] gh-141784: Fix _remote_debugging_module.c compilation on 32-bi…
5398d08 
…t Linux (#141796) (#141800)

gh-141784: Fix _remote_debugging_module.c compilation on 32-bit Linux (#141796)

Include Python.h before system headers to make sure that
_remote_debugging_module.c uses the same types (ABI) than Python.

(cherry picked from commit 722f4bb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

@ambv ambv Awaiting requested review from ambv ambv is a code owner

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

Assignees

@vstinner vstinner

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vstinner @pablogsal