gh-120158: Fix inconsistent monitoring state when setting events too frequently #141845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we overflowed the global version counter (i.e., after 2*24 calls to _PyMonitoring_SetEvents), we bailed out after setting global monitoring events but before insturmenting code objects, which led to assertion errors later on. Also add a time.sleep() to test_free_threading.test_monitoring to avoid overflowing the global version counter.
colesbury
added
needs backport to 3.13
colesbury
added
the
🔨 test-with-refleak-buildbots
|
🤖 New build scheduled with the buildbot fleet by @colesbury for commit 9a7360f 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F141845%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-refleak-buildbots
gaogaotiantian
approved these changes
Nov 22, 2025
|
Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 23, 2025
…s too frequently (pythongh-141845) If we overflowed the global version counter (i.e., after 2*24 calls to `_PyMonitoring_SetEvents`), we bailed out after setting global monitoring events but before instrumenting code objects, which led to assertion errors later on. Also add a `time.sleep()` to `test_free_threading.test_monitoring` to avoid overflowing the global version counter. (cherry picked from commit e457d60) Co-authored-by: Sam Gross <colesbury@gmail.com>
|
GH-141879 is a backport of this pull request to the 3.14 branch. |
|
Sorry, @colesbury, I could not cleanly backport this to |
colesbury
added a commit
to colesbury/cpython
that referenced
this pull request
Nov 23, 2025
…g events too frequently (pythongh-141845) If we overflowed the global version counter (i.e., after 2*24 calls to `_PyMonitoring_SetEvents`), we bailed out after setting global monitoring events but before instrumenting code objects, which led to assertion errors later on. Also add a `time.sleep()` to `test_free_threading.test_monitoring` to avoid overflowing the global version counter. (cherry picked from commit e457d60) Co-authored-by: Sam Gross <colesbury@gmail.com>
|
GH-141880 is a backport of this pull request to the 3.13 branch. |
colesbury
added a commit
that referenced
this pull request
Nov 23, 2025
…ts too frequently (gh-141845) (gh-141880) If we overflowed the global version counter (i.e., after 2*24 calls to `_PyMonitoring_SetEvents`), we bailed out after setting global monitoring events but before instrumenting code objects, which led to assertion errors later on. Also add a `time.sleep()` to `test_free_threading.test_monitoring` to avoid overflowing the global version counter. (cherry picked from commit e457d60)
colesbury
added a commit
that referenced
this pull request
Nov 23, 2025
…ts too frequently (gh-141845) (gh-141879) If we overflowed the global version counter (i.e., after 2*24 calls to `_PyMonitoring_SetEvents`), we bailed out after setting global monitoring events but before instrumenting code objects, which led to assertion errors later on. Also add a `time.sleep()` to `test_free_threading.test_monitoring` to avoid overflowing the global version counter. (cherry picked from commit e457d60) Co-authored-by: Sam Gross <colesbury@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we overflowed the global version counter (i.e., after 2*24 calls to
_PyMonitoring_SetEvents), we bailed out after setting global monitoring events but before instrumenting code objects, which led to assertion errors later on.Also add a
time.sleep()totest_free_threading.test_monitoringto avoid overflowing the global version counter.test_free_threading.test_monitoring.SetProfileMultiThreaded.test_instrumentation#120158