gh-141926 : Add --enable-cross-run configure option to avoid clearing RUNSHARED on cross-compile
#141927
+54
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
requested review from
AA-Turner,
corona10,
emmatyping and
erlend-aasland
as code owners
zanieb
force-pushed
the
zb/enable-cross-run
branch
from
183de5a to
4bf071f
Compare
…D` on cross-compile
zanieb
force-pushed
the
zb/enable-cross-run
branch
from
4bf071f to
62d8ec6
Compare
Contributor
Author
|
Closing in favor of #141958 unless someone suggests otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fairly simple start to address #141926 by retaining
RUNSHAREDvia an opt-in configure flag.A subsequent pull request could add the ability to automatically check if a cross-compiled binary can be executed.