gh-141930: Retry writing .pyc files if incomplete #141931
Open
+58
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanor
requested review from
brettcannon,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
brettcannon
reviewed
Nov 25, 2025
|
All commit authors signed the Contributor License Agreement. |
Interruption by a system call or something is not completely unexpected. Retry the write with the remaining data.
stefanor
force-pushed
the
retry-pyc-write
branch
from
4d74676 to
914caf1
Compare
Contributor
Author
|
Squashed in that suggestion to avoid the CLA bot. |
cmaloney
reviewed
Nov 26, 2025
| # Raise an OSError so the 'except' below cleans up the partially | ||
| # written file. | ||
| raise OSError("os.write() didn't write the full pyc file") | ||
| with _io.FileIO(fd, 'wb') as file, _io.BufferedWriter(file) as writer: |
Contributor
There was a problem hiding this comment.
I think just with open(fd, 'wb') as file should work here.
Could technically pass the _os.open as an opener (open(opener=_os.open(...))) but I don't think that actually makes the code simpler/more straightforward
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Writes are not guaranteed to complete by the operating system. Use
BufferedWriterto do the necessary retries and raise appropriate errors, if we fail to completely write a.pycfile in one syscall.