Skip to content

GH-141861: Fix TRACE_RECORD if full #141959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

GH-141861: Fix TRACE_RECORD if full #141959

wants to merge 4 commits into from
+5 −5

Conversation

@sergey-miryanov
Copy link
Contributor

@sergey-miryanov sergey-miryanov commented Nov 25, 2025 •
edited by bedevere-app bot
Loading

Not sure about adding news entry. Will skip it now.

@bedevere-app bedevere-app bot mentioned this pull request Nov 25, 2025
Open
@sergey-miryanov
Copy link
Contributor Author

sergey-miryanov commented Nov 25, 2025

@markshannon @Fidget-Spinner Could you please take a look?

@sergey-miryanov
Copy link
Contributor Author

sergey-miryanov commented Nov 25, 2025

Failed as in #141956.
So not sure that the failed test is related to the PR.

@sergey-miryanov
Copy link
Contributor Author

sergey-miryanov commented Nov 25, 2025

It seems related. Looking into it.

@sergey-miryanov
Copy link
Contributor Author

sergey-miryanov commented Nov 25, 2025

Here https://github.com/python/cpython/pull/140310/files condition in the test_jit_is_active was changed from expected = {enabled} and i == _testinternalcapi.TIER2_THRESHOLD to expected = {enabled} and i >= _testinternalcapi.TIER2_THRESHOLD + 1

IIUC, TIER2_THRESHOLD already contains a +1 for tracing iteration. So if i reach TIER2_THRESHOLD then jit is enabled.

@markshannon markshannon changed the title GH-141861: Fix TRACE_RECOPD if full GH-141861: Fix TRACE_RECORD if full Nov 25, 2025
Fidget-Spinner
Fidget-Spinner approved these changes Nov 25, 2025
View reviewed changes
Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

No one assigned

Labels

awaiting merge skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sergey-miryanov @Fidget-Spinner