gh-140125: Increase object recursion depth for test_json from 200k to 500k
#142226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
From some microbenchmarks, this adds like 80ms or so on my machine, which seems negligible. |
zanieb
changed the title
test_json from 200k to 500ktest_json from 200k to 500k
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_jsoncasetest_highly_nested_objects_decodingfails under PGO on Clang 20 #140125It appears increasing this recursion depth of the object resolves the issue where it can fail to hit the stack limit on macOS during PGO.
The PGO test runtime seemed unaffected on macOS and the test runtime in CI here seems within noise.