-
-
Notifications
You must be signed in to change notification settings - Fork 33.6k
gh-131372: Include LDVERSION and EXE in base_interpreter value #142256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
In Fedora, build-details.json created and installed for python3.14t contains "/usr/bin/python3.14" as the base_interpreter value. Create a correct string, taking into account both LDVERSION and EXE config variables, similarly to how it's defined in altbininstall in Makefile.
|
This change alone doesn't work, since Free Threading or Debug Build would override |
|
A single I'll note that Fedora already installs the "regular" optimized build last, precisely to overwrite any common files. |
|
Anyway, this PR fixes an issue you get when installing only the free-threaded build, for example. |
Only debug builds would, free-threading has its own directory, as of GH-121293. I opened GH-142269 to only include |
FFY00
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @befeleme, this looks good. Could you just add a news file, and then we can merge?
|
Thank you for adding the news entry! |
|
No worries! This should have been merged already, but it looks like it was a fluke in the CI. I just restarted it, so hopefully it will merge anytime now 😊 |
Ah. We should just update the branch to fix this CI illness. |
When looking at #131372 with @encukou we've realized there could be an easy fix to the first issue described there.
In Fedora, build-details.json created and installed for python3.14t contains "/usr/bin/python3.14" as the base_interpreter value. Create a correct string, taking into account both LDVERSION and EXE config variables, similarly to how it's defined in altbininstall in Makefile.
cpython/Makefile.pre.in
Line 2448 in 1a7824a