Skip to content

Conversation

@befeleme
Copy link
Contributor

@befeleme befeleme commented Dec 4, 2025

When looking at #131372 with @encukou we've realized there could be an easy fix to the first issue described there.

In Fedora, build-details.json created and installed for python3.14t contains "/usr/bin/python3.14" as the base_interpreter value. Create a correct string, taking into account both LDVERSION and EXE config variables, similarly to how it's defined in altbininstall in Makefile.

(cd $(DESTDIR)$(BINDIR); $(LN) python$(LDVERSION)$(EXE) python$(VERSION)$(EXE)); \

In Fedora, build-details.json created and installed for python3.14t
contains "/usr/bin/python3.14" as the base_interpreter value.
Create a correct string, taking into account both LDVERSION and EXE
config variables, similarly to how it's defined in altbininstall in Makefile.
@vstinner
Copy link
Member

vstinner commented Dec 4, 2025

This change alone doesn't work, since Free Threading or Debug Build would override build-details.json installed by the regular Release Build. We should decide first if we have a single build-details.json, or one per build. (I suggest discussing that on the issue.)

@encukou
Copy link
Member

encukou commented Dec 4, 2025

A single build-details.json is specified in the current PEP. We can always add new ones, but I think the "main" one should stay.

I'll note that Fedora already installs the "regular" optimized build last, precisely to overwrite any common files.

@encukou
Copy link
Member

encukou commented Dec 4, 2025

Anyway, this PR fixes an issue you get when installing only the free-threaded build, for example.
The interpreter name that generate-build-details comes up with doesn't match what's in the Makefile.

@FFY00
Copy link
Member

FFY00 commented Dec 4, 2025

This change alone doesn't work, since Free Threading or Debug Build would override build-details.json installed by the regular Release Build.

Only debug builds would, free-threading has its own directory, as of GH-121293.

I opened GH-142269 to only include build-details.json in make install, debug builds installed with make altinstall should no longer include it. I think that makes sense.

Copy link
Member

@FFY00 FFY00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @befeleme, this looks good. Could you just add a news file, and then we can merge?

FFY00 added 2 commits December 5, 2025 14:10
Signed-off-by: Filipe Laíns <lains@riseup.net>
@FFY00 FFY00 enabled auto-merge (squash) December 9, 2025 14:24
@befeleme
Copy link
Contributor Author

Thank you for adding the news entry!

@FFY00
Copy link
Member

FFY00 commented Dec 10, 2025

No worries! This should have been merged already, but it looks like it was a fluke in the CI. I just restarted it, so hopefully it will merge anytime now 😊

@vstinner
Copy link
Member

Tests / All required checks pass (pull_request) Failing after 3s

Ah. We should just update the branch to fix this CI illness.

@FFY00 FFY00 merged commit c0d0f4b into python:main Dec 10, 2025
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants