-
-
Notifications
You must be signed in to change notification settings - Fork 33.6k
gh-138122: Make sampling profiler integration tests more resilient #142382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🤖 New build scheduled with the buildbot fleet by @pablogsal for commit 56f0d93 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F142382%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
|
🤖 New build scheduled with the buildbot fleet by @pablogsal for commit 56f0d93 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F142382%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
56f0d93 to
1682b1a
Compare
|
🤖 New build scheduled with the buildbot fleet by @pablogsal for commit 1682b1a 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F142382%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
1682b1a to
5b0a384
Compare
The tests were flaky on slow machines because subprocesses could finish before enough samples were collected. This adds synchronization similar to test_external_inspection: test scripts now signal when they start working, and the profiler waits for this signal before sampling. Test scripts now run in infinite loops until killed rather than for fixed iterations, ensuring the profiler always has active work to sample regardless of machine speed.
5b0a384 to
4599726
Compare
|
🤖 New build scheduled with the buildbot fleet by @pablogsal for commit 4599726 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F142382%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
The tests were flaky on slow machines because subprocesses could finish
before enough samples were collected. This adds synchronization similar
to test_external_inspection: test scripts now signal when they start
working, and the profiler waits for this signal before sampling.
Test scripts now run in infinite loops until killed rather than for
fixed iterations, ensuring the profiler always has active work to
sample regardless of machine speed.