Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-27470: fix documentation for -3 commandline option not warning wh… #150

Merged
merged 1 commit into from Aug 4, 2017

Conversation

Projects
None yet
6 participants
@codenamesubho
Copy link
Contributor

commented Feb 18, 2017

fix documentation for -3 commandline option not warning when incompatibilities can't be detected using static code analysis

https://bugs.python.org/issue27470

@the-knights-who-say-ni

This comment has been minimized.

Copy link

commented Feb 18, 2017

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow these steps to rectify the issue:

  1. Sign the PSF contributor agreement
  2. Wait at least one US business day and then check "Your Details" on bugs.python.org to see if your account has been marked as having signed the CLA (the delay is due to a person having to manually check your signed CLA)
  3. Reply here saying you have completed the above steps

Thanks again to your contribution and we look forward to looking at it!


.. versionadded:: 2.6

.. note::

This comment has been minimized.

Copy link
@berkerpeksag

berkerpeksag Feb 22, 2017

Member

I don't think a note directive is needed here. You can say something like

See :doc:`howto/pyporting` for more details.

I haven't checked whether :doc:`howto/pyporting` works or not so please build the docs locally and test it.

This comment has been minimized.

Copy link
@codenamesubho

codenamesubho Feb 22, 2017

Author Contributor

@berkerpeksag thanks for pointing out, fixed it.

@codenamesubho codenamesubho force-pushed the codenamesubho:2.7 branch from 9ba88d7 to c5df4f7 Feb 22, 2017

bpo-27470: fix documentation for -3 commandline option not warning wh…
…en incompatibilities can't be detected using static code analysis

@codenamesubho codenamesubho force-pushed the codenamesubho:2.7 branch from c5df4f7 to d6c44f1 Feb 22, 2017

@Mariatta Mariatta changed the title bpo-27470: fix documentation for -3 commandline option not warning wh… bpo-27470 fix documentation for -3 commandline option not warning wh… Aug 4, 2017

@Mariatta Mariatta changed the title bpo-27470 fix documentation for -3 commandline option not warning wh… bpo-27470: fix documentation for -3 commandline option not warning wh… Aug 4, 2017

@Mariatta Mariatta merged commit dd6e4aa into python:2.7 Aug 4, 2017

2 checks passed

bedevere/issue-number Issue number 27470 found
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Mariatta

This comment has been minimized.

Copy link
Member

commented Aug 4, 2017

@berkerpeksag's review has been addressed.
I also tested locally that :doc:howto/pyporting works.

Thanks for the PR, @Ghost-script 🌮

akruis added a commit to akruis/cpython that referenced this pull request Mar 25, 2018

Stackless issue python#150: Add PyStackless_GetCurrentId to stackless…
…_api.h

Add the missing prototype of long PyStackless_GetCurrentId(void) to
stackless_api.h

akruis added a commit to akruis/cpython that referenced this pull request Mar 25, 2018

Stackless issue python#150: Make the thread id an unsigned integer
Commit aefa7eb in version 3.7.0a0 changed the type of thread id from
"long" to "unsigned long". This commit adapts Stackless to the new type.
See https://bugs.python.org/issue6532

akruis added a commit to akruis/cpython that referenced this pull request Sep 11, 2018

Stackless issue python#150: Add PyStackless_GetCurrentId to stackless…
…_api.h

Add the missing prototype of long PyStackless_GetCurrentId(void) to
stackless_api.h
(cherry picked from commit aa6e04c)

akruis pushed a commit to akruis/cpython that referenced this pull request Oct 29, 2018

Anselm Kruis Anselm Kruis
Stackless issue python#174: fix a buggy test case
A recently introduced test case (see Stackless issue python#150) was
buggy. It assumed sizeof(size_t) == sizeof(long) which is false
on Windows x64.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.