Skip to content

[3.7] gdbinit: Use proper define syntax (GH-19557) #19678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2020
Merged

[3.7] gdbinit: Use proper define syntax (GH-19557) #19678

merged 1 commit into from
Apr 23, 2020

Conversation

@The-Compiler
Copy link
Contributor

@The-Compiler The-Compiler commented Apr 23, 2020 •
edited by miss-islington
Loading

Using def rather than define results in:

Ambiguous command "def pu": define, define-prefix.

Automerge-Triggered-By: @csabella.
(cherry picked from commit 1221135)

Co-authored-by: Florian Bruhin me@the-compiler.org

Automerge-Triggered-By: @csabella

@The-Compiler
[3.7] gdbinit: Use proper define syntax (GH-19557)
62bb4c5 
Using `def` rather than `define` results in:

    Ambiguous command "def pu": define, define-prefix.

Automerge-Triggered-By: @csabella.
(cherry picked from commit 1221135)

Co-authored-by: Florian Bruhin <me@the-compiler.org>
@The-Compiler The-Compiler mentioned this pull request Apr 23, 2020
Merged
@The-Compiler
Copy link
Contributor Author

The-Compiler commented Apr 23, 2020

Docs run failed because GitHub is a bit broken right now...

@miss-islington miss-islington merged commit e1072d6 into python:3.7 Apr 23, 2020
@csabella
Copy link
Contributor

csabella commented Apr 23, 2020

@The-Compiler, thanks for making the backport PR and thank you for the contribution.

@The-Compiler
Copy link
Contributor Author

The-Compiler commented Apr 24, 2020

@csabella And thank you for the reviews/merges! 🎉

@The-Compiler The-Compiler deleted the backport-1221135-3.7 branch April 24, 2020 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@csabella csabella csabella approved these changes

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@The-Compiler @csabella @the-knights-who-say-ni @bedevere-bot @miss-islington