Skip to content

Improve docs of PEP 604 Union #24301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 9, 2021
Merged

Improve docs of PEP 604 Union #24301

merged 2 commits into from
Feb 9, 2021

Conversation

Fidget-Spinner
Copy link
Member

@Fidget-Spinner Fidget-Spinner commented Jan 23, 2021 •
edited
Loading

  • isinstance and issubclass descriptions for union were needlessly repetitive. They have been merged.
  • link to the docs in the what's new instead of just the PEP. It's hopefully easier to understand for a new user and not as long as the PEP.
  • update isinstance/issubclass docs to reflect them accepting unions

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jan 23, 2021
@Fidget-Spinner
Copy link
Member Author

Fidget-Spinner commented Jan 23, 2021 •
edited
Loading

@gvanrossum please take a look if you have the time. PEP 604's docs were my first piece of technical writing. In retrospect, it lacked some polish ;).

Labels:
skip news, skip issue
no backport required.

gvanrossum
gvanrossum approved these changes Feb 9, 2021
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the wait. Merging now!

@gvanrossum gvanrossum merged commit 5f77dee into python:master Feb 9, 2021
@bedevere-bot
Copy link

@gvanrossum: Please replace # with GH- in the commit message next time. Thanks!

@Fidget-Spinner Fidget-Spinner deleted the pep604-cleanup branch February 9, 2021 14:49
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@Fidget-Spinner @adorilson
Improve docs of PEP 604 Union (python#24301)
3d535fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Fidget-Spinner @bedevere-bot @gvanrossum @the-knights-who-say-ni