Skip to content

Add a warning block around the get_referrers() documentation #24511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 15, 2021
Merged

Add a warning block around the get_referrers() documentation #24511

merged 2 commits into from
Feb 15, 2021

Conversation

@pablogsal
Copy link
Member

No description provided.

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting core review labels Feb 12, 2021
Fidget-Spinner
Fidget-Spinner approved these changes Feb 13, 2021
View reviewed changes
Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested on both sphinx2 and sphinx3:
image

@pablogsal @Fidget-Spinner
Update Doc/library/gc.rst
932f5c0 
Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>
@pablogsal pablogsal merged commit 813db24 into python:master Feb 15, 2021
@miss-islington
Copy link
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8, 3.9.
🐍🍒⛏🤖

@pablogsal pablogsal deleted the gcdocs branch February 15, 2021 23:03
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 15, 2021
@pablogsal @miss-islington
Add a warning block around the get_referrers() documentation (pythonG…
70c6414 
…H-24511)

(cherry picked from commit 813db24)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Feb 15, 2021
@bedevere-bot
Copy link

GH-24542 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 15, 2021
@pablogsal @miss-islington
Add a warning block around the get_referrers() documentation (pythonG…
6cd6e54 
…H-24511)

(cherry picked from commit 813db24)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@bedevere-bot
Copy link

GH-24543 is a backport of this pull request to the 3.8 branch.

@bedevere-bot
Copy link

GH-24544 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 15, 2021
@pablogsal @miss-islington
Add a warning block around the get_referrers() documentation (pythonG…
f4f082d 
…H-24511)

(cherry picked from commit 813db24)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
miss-islington added a commit that referenced this pull request Feb 15, 2021
@miss-islington @pablogsal
Add a warning block around the get_referrers() documentation (GH-24511)
f30aa3c 
(cherry picked from commit 813db24)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
ned-deily pushed a commit that referenced this pull request Feb 16, 2021
@miss-islington @pablogsal
Add a warning block around the get_referrers() documentation (GH-24511)…
b61b20d 
… (GH-24544)

(cherry picked from commit 813db24)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@pablogsal @adorilson
Add a warning block around the get_referrers() documentation (pythonG…
8a97938 
…H-24511)
miss-islington added a commit that referenced this pull request Mar 18, 2021
@miss-islington @pablogsal
Add a warning block around the get_referrers() documentation (GH-24511)
4cc9e23 
(cherry picked from commit 813db24)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

+1 more reviewer

@codywalker77 codywalker77 codywalker77 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@pablogsal @miss-islington @bedevere-bot @Fidget-Spinner @codywalker77 @the-knights-who-say-ni