Skip to content

Conversation

@ekohl
Copy link

@ekohl ekohl commented Sep 17, 2017

Previous incorrect result for IPv4Network:

>>> ipaddress.IPv4Network('127.0.0.0/16').reverse_pointer
'0/16.0.0.127.in-addr.arpa'

New result:

>>> ipaddress.IPv4Network('127.0.0.0/16').reverse_pointer
'0.127.in-addr.arpa'

Previous incorrect result for IPv6Network:

>>> ipaddress.IPv6Network('2001:db8::/32').reverse_pointer
'2.3./.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.8.b.d.0.1.0.0.2.ip6.arpa'

New result:

>>> ipaddress.IPv6Network('2001:db8::/32').reverse_pointer
'8.b.d.0.1.0.0.2.ip6.arpa'

https://bugs.python.org/issue30528

Previous incorrect result for IPv4Network:

>>> ipaddress.IPv4Network('127.0.0.0/16').reverse_pointer
'0/16.0.0.127.in-addr.arpa'

New result:

>>> ipaddress.IPv4Network('127.0.0.0/16').reverse_pointer
'0.127.in-addr.arpa'

Previous incorrect result for IPv6Network:

>>> ipaddress.IPv6Network('2001:db8::/32').reverse_pointer
'2.3./.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.8.b.d.0.1.0.0.2.ip6.arpa'

New result:

>>> ipaddress.IPv6Network('2001:db8::/32').reverse_pointer
'8.b.d.0.1.0.0.2.ip6.arpa'
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@ekohl
Copy link
Author

ekohl commented Sep 18, 2017

I've signed the CLA and got a confirmation. Should the CLA not signed label be automatically removed?

@ayharano
Copy link

Hello there.

Sorry for the meta posting, but I would like to review this PR.

How can I review it and how can we proceed to backport it to 3.5 (according to Python official docs, ut says that reverse_pointer was new in 3.5)?

@ayharano
Copy link

@ekohl , could you include Misc/NEWS.d entry as stated in @bedevere-bot news check? ( No news entry in Misc/NEWS.d or "skip news" label found )

I am not aware how the reviews are distributed in this repo, but I would guess that at least all conflicts must be resolved to proceed.

@ekohl
Copy link
Author

ekohl commented Apr 25, 2018

@ayharano there was some discussion in the issue so I think there first needs to be a consensus on the solution. I think the best place is to start reading there and get to a solution. We can then implement it.

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Feb 22, 2022
@ekohl ekohl closed this Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review stale Stale PR or inactive for long period of time.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants