Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Nov 21, 2017

"This feature" refers to automatic concatenation of string literals, not concatenation of variable and literal.

"This feature" refers to automatic concatenation of string literals, not concatenation of variable and literal.
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

Copy link
Member

@Mariatta Mariatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think your proposed change makes sense. However I noticed you made the PR against the 3.6 branch. We work on the master branch first, and then backport it to the earlier versions.
Can you prepare another PR that targets the master branch?

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@ghost ghost mentioned this pull request Nov 24, 2017
@ghost
Copy link
Author

ghost commented Nov 24, 2017

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@Mariatta: please review the changes made to this pull request.

@Mariatta
Copy link
Member

Thanks for this PR. I merged your PR that was against master.
I'm closing this one, although it is correct, I prefer the backport PRs #4545 and #4546.
The backport PRs have more complete commit message, and they contain references to the original PR on master and the commit hash.

Thanks!

@Mariatta Mariatta closed this Nov 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants