Skip to content

Conversation

@ValeriyaSinevich
Copy link
Contributor

@ValeriyaSinevich ValeriyaSinevich commented Jul 20, 2018

Do not break out of the reading loop if SIGINT was ignored or the handler doesn't raise an exception.

https://bugs.python.org/issue28166

@ValeriyaSinevich ValeriyaSinevich changed the title Bpo-28166: Continue to read after Ctrl+C if SIGINT was ignored bpo-28166: Continue to read after Ctrl+C if SIGINT was ignored Jul 20, 2018
@zooba
Copy link
Member

zooba commented Aug 7, 2018

@ValeriyaSinevich The whitespace issue seems to be because of using tabs instead of spaces (which for some unknown reason VS still defaults to for C++...).

Replacing them with spaces (and ensuring indents of 4 spaces, which doesn't seem to be consistent in the existing code) should get you past that check.

Copy link
Contributor

@csabella csabella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ValeriyaSinevich, please address @zooba's comments about the whitespace in order to pass the CI checks. Thanks!

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@csabella
Copy link
Contributor

The original author of this pull request doesn't seem to be active anymore, so I'm going to close this PR. It can be reopened or a new pull request can be created to address the issue. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants