gh-95174: Move WASIX logic into wasi-env (GH-95320) #95320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wasi-env now sets WASIX flags. This allows us to control all build parameter for wasm32-wasi buildbot from CPython repository. Also export and improve SYSROOT parameter.
tiran
added
build
tiran
added a commit
to tiran/buildmaster-config
that referenced
this pull request
Jul 27, 2022
Instead of hard-coding build flags in the build bot configuration, wasm32-wasi buildbot now uses CPython's wasi-env script. This allows us to control the build parameters from CPython. Depends on python/cpython#95320 + backport to 3.11.
tiran
changed the title
tiran
changed the title
|
Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
Sorry @tiran, I had trouble checking out the |
tiran
added
needs backport to 3.11
|
Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 27, 2022
wasi-env now sets WASIX flags. This allows us to control all build parameter for wasm32-wasi buildbot from CPython repository. Also export and improve SYSROOT parameter. (cherry picked from commit 2833f37) Co-authored-by: Christian Heimes <christian@python.org>
|
GH-95331 is a backport of this pull request to the 3.11 branch. |
miss-islington
added a commit
that referenced
this pull request
Jul 27, 2022
wasi-env now sets WASIX flags. This allows us to control all build parameter for wasm32-wasi buildbot from CPython repository. Also export and improve SYSROOT parameter. (cherry picked from commit 2833f37) Co-authored-by: Christian Heimes <christian@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wasi-env now sets WASIX flags. This allows us to control all build
parameter for wasm32-wasi buildbot from CPython repository.
Also export and improve SYSROOT parameter.