Skip to content

Provide some example on how to leave PR reviews #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 4, 2019
Merged

Provide some example on how to leave PR reviews #452

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1bf11a9
Provide some example on how to leave PR reviews
Mariatta Feb 4, 2019
da54113
Apply suggestions from code review
terryjreedy Feb 4, 2019
a859f2f
Update pullrequest.rst
Mariatta Feb 4, 2019
2dae438
Update pullrequest.rst
Mariatta Feb 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions pullrequest.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,6 +393,21 @@ code and leave comments in the pull request or issue tracker.
However, please be aware that if you are recommending a pull request as
'merge-ready', you should always make sure the entire test suite passes.

Leaving a Pull Request Review on GitHub
---------------------------------------

When you review a pull request, you should provide additional details and context
of your review process.

Instead of simply "approving" the pull request, leave comments. For example:

#. If you tested the PR, report the result and the system and version tested on,
such as 'Windows 10', 'Ubuntu 16.4', or 'Mac High Sierra'.

#. If you request changes, try to suggest how.

#. Comment on what is "good" about the pull request, not just the "bad". Doing
so will make it easier for the PR author to find the good in your comments.

Dismissing Review from Another Core Developer
---------------------------------------------
Expand Down