[mypyc] Detect more issues when generating annotated HTML #18838
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new heuristics to detect various potential performance issues when using
-a foo.html.The issues include various generic (non-specialized) operations, uses of
functoolsanditertools, and slowisinstancechecks that use runtime-checkable protocols.Implement a mypy AST visitor that is used to detect some issues that would be harder to detect
when analyzing the generated IR.
Support annotation priorities so that if multiple annotations are generated for a line, only the
highest-priority ones are shown. This is a bit crude but useful, since often multiple heuristics
are triggered by some inefficient code, and duplicate annotations would be verbose and
sometimes confusing.