Do not update states after writing cache #19936
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Hm, |
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Also for some reason few random projects in shard 1 take much more time to check (on both old and new version). Interestingly, not the same projects on two re-runs. Maybe some problems with the GitHub runner. |
This comment has been minimized.
This comment has been minimized.
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Member
Author
|
@JukkaL to speed up things I will merge this tomorrow if there are no objections. |
JukkaL
approved these changes
Sep 30, 2025
Collaborator
JukkaL
left a comment
JukkaL
left a comment
There was a problem hiding this comment.
It would be nice to update summary to explain what goes on in more detail, but not essential.
Member
Author
|
OK, updated the description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a little preparation for #933.
We need to minimize the number of actions after writing cache, since these are things workers will need to communicate back to coordinator. Previously we updated
State.metaafter writing cache, but this looks not needed anymore, and would complicate parallel checking.Also delete couple unused attributes on
State.