Skip to content

Fix IsADirectoryError for namespace packages when using --linecoverage-report #20109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 27, 2025
+11 −0
Merged

Fix IsADirectoryError for namespace packages when using --linecoverage-report #20109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d69dded
add failing test, testReportIsADirectoryErrorCrashOnNamespacePackages
wyattscarpenter Oct 2, 2025
6d91674
fix that prevents crash
wyattscarpenter Oct 24, 2025
ff48189
Fix comment formatting in a test
ilevkivskyi Oct 27, 2025
01189b3
Merge branch 'master' into iade
ilevkivskyi Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions mypy/report.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,6 +421,9 @@ def on_file(
type_map: dict[Expression, Type],
options: Options,
) -> None:
if os.path.isdir(tree.path): # can happen with namespace packages
return

with open(tree.path) as f:
tree_source = f.readlines()

Expand Down
8 changes: 8 additions & 0 deletions test-data/unit/reports.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,6 +548,14 @@ namespace_packages = True
</body>
</html>

[case testReportIsADirectoryErrorCrashOnNamespacePackages]
# cmd: mypy --linecoverage-report report -p folder
-- Regression test for https://github.com/python/mypy/issues/18128
-- "IsADirectoryError for namespace packages when using --linecoverage-report"
[file folder/subfolder/something.py]
class Something:
pass

[case testReportCoberturaCrashOnNamespacePackages]
# cmd: mypy --cobertura-xml-report report -p folder
-- Regression test for https://github.com/python/mypy/issues/19843
Expand Down