[mypyc] Enable SIMD for librt.base64 on x86-64 #20244
Merged
+29
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-sawicki
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also generally enable SSE4.2 instructions when targeting x86-64. These have been supported by hardware since ~2010, so it seems fine to require them now.
This speeds up
b64encodeby up to 100% on Linux running on a recent AMD CPU.Some fairly recent hardware doesn't support AVX2, so it's not enabled. We'd probably need to rely on hardware capability checking for AVX2 support, and we'd need compile different files with different architecture flags probably, and I didn't want to go there (at least not yet).