Skip to content

Conversation

@ilevkivskyi
Copy link
Member

There is a bunch of code duplication in mypyc/lib-rt, but it looks like there is no way to resolve this in a reasonable way. So instead I factor out duplicated code into a separate module, and add a test to verify files are synced.

Note I type-check lib-rt separately now. Whatever I tried, I am getting weird error either like

Cannot find implementation or library stub for module named "build_setup"

or

Source file found twice under different module names: "mypyc.lib-rt.build_setup" and "build_setup"

etc. This is kind of a known problem, that we need to address long-term.

cc @JukkaL

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2025

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@ilevkivskyi ilevkivskyi merged commit 4fabef2 into python:master Dec 6, 2025
22 checks passed
@ilevkivskyi ilevkivskyi deleted the check-code-dup branch December 6, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant